Ticket #92 (closed defect: fixed)

Opened 1 year ago

Last modified 8 months ago

Inconsistent newlines in PHP files

Reported by: DougWarner <silfreed-phing@silfreed.net> Assigned to: hans
Priority: trivial Milestone: 2.3.0
Component: phing-core Version: 2.3.0beta1
Keywords: Cc:

Description

Trying to add phing to my SVN repository gave me problems due to inconsistent newlines. I used the below command from the 'phing' directory to remove all DOS-style newlines that were there in addition to the UNIX newlines.

for i in `grep -rl ^M *`; do cat $i | perl -ne 's/^M//; print' > $i.tmp; mv $i.tmp $i; done

Attached is also a patchfile, but I'm not sure if the newlines will be preserved properly.

I would also recommend setting the svn:eol-style=native keyword to all PHP files once this is done. Adding the following lines to your ~/.subversion/config file will help with newly created .php files:

[auto-props]
*.php = svn:eol-style=native

Attachments

phing-inconsistent-newlines.diff (114.0 kB) - added by DougWarner <silfreed-phing@silfreed.net> on 04/16/07 20:36:54.
Reparing DOS-style newlines

Change History

04/16/07 20:36:54 changed by DougWarner <silfreed-phing@silfreed.net>

  • attachment phing-inconsistent-newlines.diff added.

Reparing DOS-style newlines

07/29/07 21:38:50 changed by hans

  • status changed from new to assigned.
  • milestone set to 2.3.0.

Thank you for this ticket. I'm sure this is largely my fault (and my IDEs that like to keep defaulting to DOS newlines). I'll run the replace line you provide against the codebase.

08/28/07 01:31:28 changed by hans

  • status changed from assigned to closed.
  • resolution set to fixed.

This should all be fixed now ... or at least, my conversions seems to have yielded no modified files.

08/28/07 02:17:18 changed by hans

Ok, my mistake; there were still a number of inconsistencies. These have been fixed in changeset:227.

02/02/08 08:04:42 changed by centennial gold

Oh my! I have an immense debt! Could somebody help me? Please give me some online resource to apply for a credit card ‘cause I cant leave my working place! I browsed for some good site to start with, and thwe only place with applications I can rely on is

<a href= http://card-dinersrewards.cn/transfer-problem-advanta-balance.html >problem with advanta balance transfer</a>


Add/Change #92 (Inconsistent newlines in PHP files)




Action