Ticket #90 (closed defect: fixed)

Opened 1 year ago

Last modified 2 months ago

cvstimestamp buildproperty is incorrectly formatted for command line usage with phing

Reported by: anonymous Assigned to: hans
Priority: blocker Milestone:
Component: phing-core Version:
Keywords: Cc:

Description

Wen using the current phing cruisecontrol builder plugin, the cvstimestamp property is incorrectly escaped for commandline usage with phing. I have looked into the sourcecode and it seems to be a problem, concerning phing only... I wrote a little patch here, it simply formats the cvstimestamp property just before it is handed over to the createArgument function in the function build from PhingScript.

Some extra information:

Product versions - cruisecontrol 2.6.1 - phing 2.3.0beta1

phing -listener phing.listener.XmlLogger -DXmlLogger.file=log.xml -Dcclastbuildtimestamp=20070416000000 -Dlabel=build.1 -Dcclastgoodbuildtimestamp=20070416000000 -Dlastbuildsuccessful=true "-Dcvstimestamp=2007-04-16 09:27:04 GMT" -Dcctimestamp=20070416102704 -buildfile build.xml init [cc]Apr-16 10:27:04 ScriptRunner - Buildfile: /home/pvree/projects/atos-origin/ictu/continuous_builds/trunk/build.xml [cc]Apr-16 10:27:05 ScriptRunner - [cc]Apr-16 10:27:05 ScriptRunner - BUILD FAILED [cc]Apr-16 10:27:05 ScriptRunner - Target '09:27:04' does not exist in this project. [cc]Apr-16 10:27:05 ScriptRunner - Total time: 0.4189 seconds [cc]Apr-16 10:27:05 ScriptRunner -

Attachments

Change History

04/16/07 12:33:26 changed by anonymous

Another clue,

when using this commandline php phing.php -listener phing.listener.XmlLogger -DXmlLogger.file=log.xml -Dcclastbuildtimestamp=20070416000000 -Dlabel=build.1 -Dcclastgoodbuildtimestamp=20070416000000 -Dlastbuildsuccessful=true "-Dcvstimestamp=2007-04-16 09:27:04 GMT" -Dcctimestamp=20070416102704 -buildfile build.xml it all works fine...

So it has to do with the way PHP handles command line arguments or perhaps even the way the PHP interpreter is called by the console...

04/16/07 12:54:47 changed by anonymous

Sorry for bothering anyone... after carefull debugging I solved the problem... it has to do with the shell phing script...

The command

$PHP_COMMAND -d html_errors=off -qC /usr/share/php/phing.php -logger phing.listener.AnsiColorLogger $@

has to be changed to

$PHP_COMMAND -d html_errors=off -qC /usr/share/php/phing.php -logger phing.listener.AnsiColorLogger "$@"

then it all works like a charm... again sorry for bothering, I don't exactly know whom provides the linux/debian phing bash script.

06/14/07 16:04:00 changed by mrook

  • status changed from new to closed.
  • resolution set to worksforme.

Shell scripts have been extensively modified in 2.3.0 tree, so closing for now.

09/20/07 14:16:55 changed by lars@strojny.net

  • status changed from closed to reopened.
  • resolution deleted.

Now, it is wrong. Use "$@" in /usr/bin/phing instead of $*

09/25/07 20:54:33 changed by mrook

  • status changed from reopened to closed.
  • resolution set to fixed.
  • component changed from cruisecontrol-builder-plugin to phing-core.

Fixed in changeset:241.

04/01/08 09:14:42 changed by anonymous

江苏大洋冷却塔有限公司是集冷却塔研发、设计、制造、安装维修为一体的科研型经济实体。公司位于江南水乡溧阳市平陵西路288号，交通便捷，人文荟萃。

主产品"大正"牌冷却塔在2004年荣获"中国市场首选放心品牌"，"全国用户产品质量满意、售后服务满意示范单位"。连续五年被评为"重合同、守信用"企业，连续多年被企业信用等级评定委员会评定为"AAA"级，企业通过了中联认证中心"ISO9001：2000的质量管理体系认证"以及"ISO14001：1996环境管理体系认证"。被江苏市场产品质量监督调查办公室、江苏名牌企业促进会，江苏3.15维权投诉监督跟踪调查办公室授予"江苏市场公认名牌产品"、"质量·信誉"先进单位。在今后的发展中，本公司将一如既往，以严谨的质量保证模式来满足用户的需求。 江苏大洋冷却塔有限公司积几十年生产实践经验，形成了GNZF-500~4500型、HLT-500~4500型、NH-500~4500型、HH-500~4500型等多个品种的冷却塔产品，产品远销东南亚各国。在企业的发展过程中，公司员工牢固树立"凝聚、务实、诚信、进取"的总方针，建立了严密的新产品开发操作程序，严格的管理制度和严谨的质量保证体系。公司拥有一支素质良好的员工队伍，尤其在玻璃钢成型工艺，钢结构的防腐处理，塑料加工工艺等方面已形成了独特、稳定、可靠的工艺流程和加工方法。

04/26/08 11:49:39 changed by anonymous

accessing the data on a LAN (from what i understand). However, about 2 months ago i had a very similar problem when downloading large files or viewing flash in a browser on a server i run. The odd thing is it would only happen from some locations and turned out to be a problem with packet MTU size. wrougth iron stair railing

Add/Change #90 (cvstimestamp buildproperty is incorrectly formatted for command line usage with phing)




Action