Modify ↓

Ticket #349 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

JslLint task fails to escape shell argument

Reported by: felix.gilcher@… Owned by: mrook
Priority: major Milestone: 2.4.0RC1
Component: phing-tasks-ext Version: 2.3.2
Keywords: jsslint shell escape Cc:

Description

The JslLint task constructs a shell command but fails to escape the included shell metachars. The error is in line 110: 

      $command = 'jsl -output-format file:__FILE__;line:__LINE__;message:__ERROR__ -process ';

The semicolon ends the current command. A quick fix is to wrap the parameter in double quotes, a proper fix would be appropriate usage of escapshellarg/escapeshellcmd

Attachments

Change History

comment:1 Changed 13 months ago by mrook

(In [509]) Refs #349 - JslLint task fails to escape shell argument

comment:2 Changed 13 months ago by mrook

  • Status changed from new to closed
  • Resolution set to fixed

This bug has been fixed in the SVN tree, revision r509.

Thank you for the report, and for helping us make Phing better!

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.