Ticket #262 (closed defect: fixed)

Opened 20 months ago

Last modified 9 months ago

Archive_Zip fails to extract on Windows

Reported by: Marcus Welz <marcus@…> Owned by: mrook
Priority: major Milestone: 2.4.0RC1
Component: phing-tasks-ext Version: 2.3.1RC1
Keywords: Cc:

Description

(Not sure whether this is the correct place to report it, but the Archive_Zip PEAR component is not maintained by anyone at the moment.)

Archive_Zip::_extractByRule() has a bug when run under Windows. The few lines after the comment '// ----- Check the path' around line 1752 will prepend "./" to the path, if a relative path was specified. It improperly checks for ' (substr($p_path,1,2)!=":/") ' to catch absolute paths on Windows, but won't catch paths that use backslashes, (e.g. "C:\mypath\").

This ticket is somewhat related to #261.

Attachments

Change History

Changed 10 months ago by mrook

  • owner changed from hans to mrook

Since Archive_Zip has been superseded by File_Archive it might be wise to rewrite UnzipTask using this component.

Changed 9 months ago by mrook

  • status changed from new to closed
  • resolution set to fixed

A patch to rewrite UnzipTask using the PHP zip extension was committed in r443. Since we no longer use Archive_Zip in this task, this bug is deemed fixed.

Add/Change #262 (Archive_Zip fails to extract on Windows)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.