UnZip task reports success on failure on Windows

[Marcus Welz <marcus@…>]

I have an unzip task in my build.xml that appears to complete succesfully, but no files are actually extracted.

The phing/tasks/ext/UnzipTask.php doesn't properly check the results coming back from Archive_Zip::extract(). It should probably iterate over the results ($extractResponse as $extractedPath) and check whether the 'status' array element equals 'ok'.

I haven't done any testing to see what happens when Archive_Zip tries to extract files that already exist, or what should happen in that case (probably not overwrite them, and still report success, similar to how mkdir commands are ignored for already existing directories.)

There's a separate issue with Archive_Zip that I'll file in its own ticket.

[Marcus Welz <marcus@…>]

#262 is related to this issue.

[mrook]

A patch to rewrite UnzipTask using the PHP zip extension was committed in r443. Since we no longer use Archive_Zip in this task, this bug is deemed fixed.