Ticket #183 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Undefined variable in PhingTask.php

Reported by: Oz Solomon Assigned to: hans
Priority: trivial Milestone: 2.3.1
Component: phing-core Version: 2.3.0
Keywords: Cc:

Description

Line 162 of PhingTask.php is

$buildFailed = false;

That line needs to move to the beginning of the processFile() function (line 201).

As it currently stands, when you reach this line at the end of processFile()

if ($this->haltOnFailure && $buildFailed) {

If there was no exception, then $buildFailed is undefined.

Attachments

Change History

11/08/07 20:40:40 changed by hans

  • status changed from new to closed.
  • resolution set to fixed.

Wow .. thank you again, yes. This is fixed in r303 (and r304, trunk).

P.S. Do you want an SVN account to help fix these issues as you find them? Please send a note to the dev list if you would like an account.

Add/Change #183 (Undefined variable in PhingTask.php)




Action