Ticket #181 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

PhingCallTask should call setHaltOnFailure

Reported by: Oz Solomon Assigned to: hans
Priority: major Milestone: 2.3.1
Component: phing-core Version: 2.3.0
Keywords: Cc:

Description

Problem: <phingcall> silently eats up all failures.

Technical Description: <phingcall> is implemented by PhingCallTask which in turn uses PhingTask. The problem is that PhingTask defaults to haltonerror=false. This is not the expected behavior when calling a task within the same build file.

The solution is to add the line in bold to PhingCallTask.php:

function init() {

$this->callee = $this->project->createTask("phing"); $this->callee->setOwningTarget($this->getOwningTarget()); $this->callee->setTaskName($this->getTaskName()); $this->callee->setHaltOnFailure(true); // add this

$this->callee->init();

}

Attachments

Change History

11/08/07 20:31:57 changed by hans

  • status changed from new to closed.
  • resolution set to fixed.

Good suggestion, yes. This is fixed in r299 (and r300 in trunk)


Add/Change #181 (PhingCallTask should call setHaltOnFailure)




Action