Ticket #168 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

XincludeFilter PHP Error

Reported by: padraic.brady@yahoo.com Assigned to: hans
Priority: major Milestone: 2.3.0
Component: phing-core Version: 2.3.0RC1
Keywords: xinclude xslt reader Cc:

Description

On line 79 of the XincludeFilter class file for 2.3.0RC1, there is a reference to a toString() function called on the private Reader object. The Reader object however does not implement a toString() method. The result is that any Xslt task using the XincludeFilter fails with a fatal error reported from BufferedReader.

Attachments

Change History

(in reply to: ↑ description ) 10/24/07 22:24:25 changed by padraic.brady@yahoo.com

Replying to padraic.brady@yahoo.com:

On line 79 of the XincludeFilter class file for 2.3.0RC1, there is a reference to a __toString() function called on the private Reader object. The Reader object however does not implement a __toString() method. The result is that any Xslt task using the XincludeFilter fails with a fatal error reported from BufferedReader.

10/24/07 22:28:42 changed by hans

  • status changed from new to assigned.

Ok, I changed this to use getResource() in [264] (2.3) and [263] (trunk). That is the approach we use for XSLT, so I assume this is also desired for this filter.

Please test this if you can (since I did not test it just now). Otherwise I will test later and then close.

(in reply to: ↑ description ) 10/25/07 16:29:06 changed by padraic.brady@yahoo.com

The change doesn't cause any problems at least ;). I think you can close this one.

10/25/07 18:18:05 changed by hans

  • status changed from assigned to closed.
  • resolution set to fixed.

Thsnks for the follow up.

Add/Change #168 (XincludeFilter PHP Error)




Action